Re: [coreutils] Feature: Introduce fiemap copy to cp(1) and mv(1) v2

[Pádraig Brady]

On 09/04/10 14:41, jeff.liu wrote:
> Hello All,
> 
> Please ignore the previous patchsets, there is an issue I just fixed.
> 
> The revised version were shown as following:
> 
> From: Jie Liu <address@hidden>
> Date: Fri, 9 Apr 2010 21:31:27 +0800
> Subject: [PATCH 1/2] Add fiemap.h for fiemap ioctl(2) support.
> 
> diff --git a/src/fiemap.h b/src/fiemap.h
> new file mode 100644
> index 0000000..d33293b
> --- /dev/null
> +++ b/src/fiemap.h

I guess we should emulate this only when fiemap.h is not available

> +# include <linux/types.h>

The emulation should not need the above #include

> From: Jie Liu <address@hidden>
> Date: Fri, 9 Apr 2010 21:38:23 +0800
> Subject: [PATCH 1/1] Add fiemap copy for cp(1).
>  This feature is intended to for optimization of backup sparse files.
> 
> Fiemap copy can be trigger via 'cp --fiemap=[WHEN]', if 'fiemap=auto' specify 
> and
> the underlying FS does not support FIEMAP or fiemap copy failed, fall back to
> normal copy.

I'm not convinced this feature needs any options.
I.E. any reason for not always trying this and falling back if not possible?

cheers,
Pádraig.