[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new snapshot available: coreutils-8.20.119-54cdb0

From: Assaf Gordon
Subject: Re: new snapshot available: coreutils-8.20.119-54cdb0
Date: Tue, 12 Feb 2013 15:32:06 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4

Pádraig Brady wrote, On 02/12/2013 04:18 AM:
> On 02/12/2013 04:45 AM, Assaf Gordon wrote:
>> On Feb 11, 2013, at 20:32, Pádraig Brady <address@hidden> wrote:
>>> On 02/11/2013 08:47 PM, Assaf Gordon wrote:
>>>> +  if (errno != 0 && (errno != EINVAL))
>>> It might be better to do:
>>> if (errno == ERANGE)
>>>   error ();
>> I was thinking about that, my only concern was since we're already dealing 
>> with non-standard code, should we worry about an even weirder implementation 
>> that might return something that's not ERANGE and not EINVAL?
> The error message is just about ERANGE, so it's probably
> best to use just that value in the conditional.
> Reading the docs, EINVAL is the only other possibility.

Attached updated patch.


Attachment: 0001-numfmt-fix-strtol-bug.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]