Re: coreutils-9.0.193-54bec on Solaris 11.4

[Bruno Haible]

Pádraig Brady wrote:
> > FAIL: tests/misc/stty-row-col
> > =============================
> 
> Any of the commands like `stty rows 40 columns 80` are being silently ignored.
> FWIW on the Solaris 10 system I've access to, this test passes.
> I'd need access to investigate.

I'm sorry, the license terms from Oracle
https://www.oracle.com/downloads/licenses/solaris-cluster-express-license.html
("You may not: ... make the Programs available in any manner to any third party
...")
don't given me permission to give you or anyone else access to my VM. It's
proprietary software. I can only share the instructions to build a VM.

> > FAIL: tests/install/basic-1
> > ===========================
> > FAIL: tests/mv/diag
> > ===================
> 
> These two are the same issue I think ...
> 
> diff --git a/src/system.h b/src/system.h
> index c24cb4dc3..d2c473a59 100644
> --- a/src/system.h
> +++ b/src/system.h
> @@ -140,9 +140,12 @@ target_directory_operand (char const *file)
>     bool is_a_dir = false;
>     struct stat st;
> 
> -  /* On old systems like Solaris 10, check with stat first
> -     lest we try to open a fifo for example and hang.  */
> -  if (!O_DIRECTORY && stat (file, &st) == 0)
> +  /* On old systems without O_DIRECTORY, like Solaris 10,
> +     check with stat first lest we try to open a fifo for example and hang.
> +     Also check on systems with O_PATHSEARCH == O_SEARCH, like Solaris 11,
> +     where open was seen to return EPERM for non directories.  */
> +  if (!O_DIRECTORY || (O_PATHSEARCH == O_SEARCH)
> +      && stat (file, &st) == 0)

Isn't there a parenthesizing mistake here? I would write
     if ((!O_DIRECTORY || (O_PATHSEARCH == O_SEARCH))
         && stat (file, &st) == 0)

This patch does not apply cleanly to the snapshot source. I tried
a similar patch, but it did not help.

> > FAIL: tests/tail-2/pipe-f
> > =========================
> 
> The following might help here:
> 
> diff --git a/src/tail.c b/src/tail.c
> index f1b741783..a28fa61da 100644
> --- a/src/tail.c
> +++ b/src/tail.c
> @@ -356,7 +356,7 @@ check_output_alive (void)
>        event immediately) or if using inotify (which relies on 'poll'
>        anyway).  Otherwise, use 'select' as it's more portable;
>        'poll' doesn't work for this application on macOS.  */
> -#if defined _AIX || HAVE_INOTIFY
> +#if defined _AIX || defined __sun || HAVE_INOTIFY
>     struct pollfd pfd;
>     pfd.fd = STDOUT_FILENO;
>     pfd.events = POLLERR;

I tried this change, together with an analogous change in line 58
(otherwise it would not compile). It does not fix the test failure;
new test-suite.log is attached.

Bruno

test-suite.log
Description: Text Data