Re: gnuradio-releases PPA installs files different from v3.9.0.0 tag

[schneider]

Hi josh,

On 04.03.21 16:12, Josh wrote:
> schneider,
> 
> I installed gr from the PPA into a fresh docker and it looks like the
> header in /usr/include/gnuradio/filter/fir_filter.h matches the commit
> in that the decimation argument has been removed.  Is it possible that
> the version from the PPA didn't install cleanly and it is referencing a
> header from somewhere else?

I installed it inside a virtual machine with a fresh Ubuntu 20.04.2 LTS
installation. This is what I got:

$ dpkg -l | grep gnuradio-filter
ii  libgnuradio-filter:amd64
3.9.0.0git~master~14059~focal-4   amd64        gnuradio filter functions

$ md5sum /usr/include/gnuradio/filter/fir_filter.h
48049333c1cea0b522a397159553f186  /usr/include/gnuradio/filter/fir_filter.h


The MD5 sum matches the version of this file from commit d20a7732e:

gnuradio ((d20a7732e...))$ md5sum
gr-filter/include/gnuradio/filter/fir_filter.h
48049333c1cea0b522a397159553f186
gr-filter/include/gnuradio/filter/fir_filter.h


The 3.9.0.0 release tag has two more commits for this file:

gnuradio ((v3.9.0.0))$ git log --oneline
gr-filter/include/gnuradio/filter/fir_filter.h
0c62af72f fir_filter: in constructor, 'decimation' is unused
b39c64d7e filter: remove needless empty destructors and problematic const
d20a7732e filter: Remove manual memory management

I'm still at a loss...

Best
schneider

> 
> Josh
> 
> On Wed, Mar 3, 2021 at 4:32 PM schneider <schneider@xtort.eu
> <mailto:schneider@xtort.eu>> wrote:
> 
>     Hi,
> 
>     I've just installed GNURadio 3.9.0.0 from the `gnuradio-releases` PPA on
>     a fresh Ubuntu 20.04.
> 
>     I'm now facing an issue with compiling an OOT module: The constructor of
>     `gr::filter::kernel::fir_filter` is expecting a decimation argument.
>     That argument is not present in v3.9.0.0 anymore though.
> 
>     This commit introduced the change and it is part of v3.9.0.0:
>     
> https://github.com/gnuradio/gnuradio/commit/0c62af72fe30c0a9009fe7cbb6de2efc853b7d37
> 
> 
>     Is it possible that the PPA was built from a different checkout?
> 
> 
>     Best
>     schneider
> 
>