Re: Fractional values for the content view of a Tab

[Fred Kiefer]

Thank you for pointing at that code here. I already had put in a comment 
that it needs clean up, but never got around to that. I tried to make 
the values here consistent with the ones in GSThemeDrawing. But of 
course this is only the first step. The values should come from the 
theme, to allow themes to have different styles for the tabs and more 
importantly, the tab view should be flipped.
We need to clean all that up, but should do so after the release.

Could you please give the new values a try and report back whether they 
work for you. I only tested with NSTopTabsBezelBorder, which should be 
the most common case.

Fred

On 22.02.2013 02:00, Riccardo Mottola wrote:
> I propose the patch below (in the quest of why MDIndexer has a blurry
> UI). It solves the visualization inside Gorm, which now looks correct,
> but it still doesn't fix the visualization inside SystemPreferences.
>
> What do you think?
>
> Riccardo
>
> Index: Source/NSTabView.m
> ===================================================================
> --- Source/NSTabView.m  (revision 36181)
> +++ Source/NSTabView.m  (working copy)
> @@ -390,7 +390,7 @@
>     switch (_type)
>       {
>         case NSTopTabsBezelBorder:
> -        return NSMakeSize(2, 19.5);
> +        return NSMakeSize(2, 19);
>         case NSNoTabsBezelBorder:
>           return NSMakeSize(2, 3);
>         case NSNoTabsLineBorder:
> @@ -421,19 +421,19 @@
>       {
>         case NSTopTabsBezelBorder:
>           cRect.origin.y += 1;
> -        cRect.origin.x += 0.5;
> +        cRect.origin.x += 1;
>           cRect.size.width -= 2;
> -        cRect.size.height -= 18.5;
> +        cRect.size.height -= 19;
>           break;
>         case NSNoTabsBezelBorder:
>           cRect.origin.y += 1;
> -        cRect.origin.x += 0.5;
> +        cRect.origin.x += 1;
>           cRect.size.width -= 2;
>           cRect.size.height -= 2;
>           break;
>         case NSNoTabsLineBorder:
>           cRect.origin.y += 1;
> -        cRect.origin.x += 0.5;
> +        cRect.origin.x += 1;
>           cRect.size.width -= 2;
>           cRect.size.height -= 2;
>           break;