[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: cairo crash on NetBSD/sparc
From: |
Fred Kiefer |
Subject: |
Re: cairo crash on NetBSD/sparc |
Date: |
Thu, 08 Jan 2015 21:33:53 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
I just commited Eric's patch, plus one extra check.
Fred
Am 06.01.2015 um 09:52 schrieb Riccardo Mottola:
> Hi Eric,
>
> Eric Wasylishen wrote:
>> Hi,
>> This is the code that adds a list of spelling suggestions to the
>> context menu if you right-click a misspelled word.
>>
>> I wasn't expecting [NSSpellChecker sharedSpellChecker] to return nil
>> and/or forgot about the issue where [nil someMethodThatReturnsAStruct]
>> is unsafe on some systems.
> Well the latter is for sure true on SPARC, I don't know about other archs.
>
> About the first I don't know. I don't have aspell configured, thus
> probably certain code-paths are disabled. Could it be that or instead
> the log message just above the crash:
>
> 2015-01-05 19:22:49.436 Ink[539] Model file load failed for GSSpellPanel
>
>> Changing that line to:
>>
>> if (sp != nil && [sp checkSpellingOfString...
>>
>> should fix the problem.
> I'll try that tomorrow. and let you know. Thank you!
>
> Riccardo
>
>