[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#39570: closed ([PATCH] go: update to 1.13)

From: GNU bug Tracking System
Subject: bug#39570: closed ([PATCH] go: update to 1.13)
Date: Tue, 11 Feb 2020 22:56:02 +0000

Your message dated Tue, 11 Feb 2020 22:55:19 +0000
with message-id <address@hidden>
and subject line Re: [PATCH] go: update to 1.13
has caused the debbugs.gnu.org bug report #39570,
regarding [PATCH] go: update to 1.13
to be marked as done.

(If you believe you have received this mail in error, please contact

39570: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=39570
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: go: update to 1.13 Date: Tue, 11 Feb 2020 14:45:27 -0500 (EST) User-agent: Alpine 2.20 (DEB 67 2015-01-07)
Hi Guix,

The following is the minimal patch to update Go to 1.13. I'm motivated to do this, in part, because of the go modules transition [0]. In the short term, this will allow users of the go tooling to use the newest modules behavior. The Guix go tooling, however, is not ready for modules [1], so in this commit, I configure the go-build-system to use the old behavior. Eventually the switch to do so will go away upstream, so we'll need to update the build system.

Some things to be aware of when reviewing:

I believe that in Go 1.13, the upstream issued that lead to excessive references being maintained in go programs [2] has been fixed, but I did not undo our workaround.

With 1.13 the behavior of `go get` changed to download packages from Google's mirror at proxy.golang.org by default [3] as opposed to directly from upstream. This is configurable by users, and I don't think it is a FSDG issue (if it is, I think it would be on privacy grounds), but we could change the default behavior if needed.

I replaced the go-1.12 package with go-1.13, rather than having both.

guix refresh -l go says that "Building the following 51 packages would ensure 175 dependent packages are rebuilt," so I have prepared the commit against master.

I tested the commit by building syncthing and restic on my x86_64 system.

[0] https://blog.golang.org/v2-go-modules
[1] https://lists.gnu.org/archive/html/guix-devel/2020-02/msg00110.html
[2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33620
[3] https://golang.org/doc/go1.13#modules


--- End Message ---
--- Begin Message --- Subject: Re: [PATCH] go: update to 1.13 Date: Tue, 11 Feb 2020 22:55:19 +0000 User-agent: Cyrus-JMAP/3.1.7-802-g7a41c81-fmstable-20200203v1
I just split this up into 2 patches and committed to master. Thanks for 

Alex Griffin

--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]