bug#40591: closed (Add emacs-org-roam)

[GNU bug Tracking System]

Your message dated Tue, 14 Apr 2020 11:08:52 +0200
with message-id <address@hidden>
and subject line Re: [bug#40591] Add emacs-org-roam
has caused the debbugs.gnu.org bug report #40591,
regarding Add emacs-org-roam
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
40591: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40591
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: Add emacs-org-roam Date: Sun, 12 Apr 2020 22:58:03 -0500 User-agent: mu4e 1.2.0; emacs 26.3

Hello.

Added emacs-org-roam. I used it all day, seems like  everything works.
guix size is around 0.2 MB

0001-gnu-Add-emacs-org-roam.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#40591] Add emacs-org-roam
>
>
>
>
> Date: 
>
> Tue, 14 Apr 2020 11:08:52 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
>
>
>
>
> Hello,
>
> Alberto EFG <address@hidden> writes:
>
> > Added emacs-org-roam. I used it all day, seems like  everything works.
>
> Thank you. 
>
> I applied your patch with the following changes.
> > +(define-public emacs-org-roam
> > +  (package
> > +   (name "emacs-org-roam")
>
> The indentation is off. If you use Emacs, you can press M-q, otherwise,
> you may call the etc/indent.el script in Guix source tree.
>
> > +   (version "1.0.0")
> > +   (source
> > +    (origin
> > +     (method git-fetch)
> > +     (uri (git-reference
> > +           (url "https://github.com/jethrokuan/org-roam.git";)
> > +           (commit "1433dbc31602c412914c71ecc81aa5dcf6b03daf")))
>
> When there is an official release, we use the tag. Therefore, I changed
> the line above to:
>
>   (commit (string-append "v" version))
>
> > +     (file-name (git-file-name name version))
> > +     (sha256
> > +      (base32
> > +       "08pfa63k194dpk0y2gfa0nzn5lig81q0l9axkq5j4ibj6ifaap4a"))))
>
> Nitpick: I put the string on the line above.
>
> > +   (build-system emacs-build-system)
> > +   (propagated-inputs
> > +    `(("emacs-company" ,emacs-company)
> > +      ("emacs-emacsql-sqlite" ,emacs-emacsql)
> > +      ("emacs-dash" ,emacs-dash)
> > +      ("emacs-f" ,emacs-f)
> > +      ("emacs-s" ,emacs-s)
> > +      ("emacs-org-ref" ,emacs-org-ref)))
>
> I re-ordered the inputs alphabetically.
>
> > +   (license license:gpl3)))
>
> The license is actually gpl3+, as written in the source code.
>
> Regards,
>
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---