emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#40593: closed (Added emacs-uml-mode)


From: GNU bug Tracking System
Subject: bug#40593: closed (Added emacs-uml-mode)
Date: Tue, 14 Apr 2020 09:13:02 +0000

Your message dated Tue, 14 Apr 2020 11:12:33 +0200
with message-id <address@hidden>
and subject line Re: [bug#40593] Added emacs-uml-mode
has caused the debbugs.gnu.org bug report #40593,
regarding Added emacs-uml-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden.)


-- 
40593: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=40593
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Added emacs-uml-mode Date: Mon, 13 Apr 2020 01:15:41 -0500 User-agent: mu4e 1.2.0; emacs 26.3
Added emacs-uml-mode. I used the same branch where I wrote
emacs-org-roam (bug#40591) hope it is ok.

guix size is 0.1 MB

The package is just an emacs file, there should not be much problem.

>From 0289b51837ea2edfe610deb2e91ee329601f1234 Mon Sep 17 00:00:00 2001
From: Alberto Eleuterio Flores Guerrero <address@hidden>
Date: Mon, 13 Apr 2020 01:07:04 -0500
Subject: [PATCH] gnu: Add emacs-uml-mode.

* gnu/packages/emacs-xyz.scm (emacs-uml-mode): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0f1c48be2e..0fdc509038 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22332,3 +22332,25 @@ without hierarchy and are connected by tags.  Notes 
can be found
 and created quickly.  Org-roam should also work as a plug-and-play
  solution for anyone already using Org-mode for their personal wiki.")
    (license license:gpl3)))
+
+(define-public emacs-uml-mode
+  (package
+   (name "emacs-uml-mode")
+   (version "0.0.4")
+   (source
+    (origin
+     (method git-fetch)
+     (uri (git-reference
+           (url "https://github.com/ianxm/emacs-uml.git";)
+           (commit "4c37ac1c4424b2313cd8f16ba48a98a4cc214200")))
+     (file-name (git-file-name name version))
+     (sha256
+      (base32
+       "145i4srnfvd1vyibri2a1l6p9mbjvkkwlrpi41134pbarqffcnka"))))
+   (build-system emacs-build-system)
+   (home-page "https://github.com/ianxm/emacs-uml";)
+   (synopsis "Minor mode for editing ascii UML sequence diagrams")
+   (description "@code{emacs-uml-mode} is a minor mode that
+ makes it easy to build ascii UML sequence diagrams in Emacs,
+which can be embedded in source code, comments or emails.")
+   (license license:gpl3)))
-- 
2.26.0


--- End Message ---
--- Begin Message --- Subject: Re: [bug#40593] Added emacs-uml-mode Date: Tue, 14 Apr 2020 11:12:33 +0200 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Hello,

Alberto EFG <address@hidden> writes:

> Added emacs-uml-mode. I used the same branch where I wrote
> emacs-org-roam (bug#40591) hope it is ok.

Thank you.

Note that adding all new packages at the end of the file is likely to
create merge conflicts. If they are tied, send them in the same bug
report.

> +(define-public emacs-uml-mode
> +  (package
> +   (name "emacs-uml-mode")
> +   (version "0.0.4")

This is not an official release. So I added a commit, a revision, and
a comment. Therefore, the line became:

  (version (git-version "0.0.4" revision commit))

> +   (source
> +    (origin
> +     (method git-fetch)
> +     (uri (git-reference
> +           (url "https://github.com/ianxm/emacs-uml.git";)
> +           (commit "4c37ac1c4424b2313cd8f16ba48a98a4cc214200")))

As a consequence of the "no revision" situation, the line above  became:

  (commit commit)

> +     (file-name (git-file-name name version))
> +     (sha256
> +      (base32
> +       "145i4srnfvd1vyibri2a1l6p9mbjvkkwlrpi41134pbarqffcnka"))))
> +   (build-system emacs-build-system)
> +   (home-page "https://github.com/ianxm/emacs-uml";)
> +   (synopsis "Minor mode for editing ascii UML sequence diagrams")
> +   (description "@code{emacs-uml-mode} is a minor mode that
> + makes it easy to build ascii UML sequence diagrams in Emacs,
> +which can be embedded in source code, comments or emails.")
> +   (license license:gpl3)))

Please also see my comments about "emacs-org-roam" (indentation, commit,
license).

Regards,

-- 
Nicolas Goaziou


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]