bug#48016: closed ([PATCH] gnu: direnv: Install manpages)

[GNU bug Tracking System]

Your message dated Sun, 25 Apr 2021 13:44:06 -0400
with message-id <YIWqZnDtEq/R/hBO@jasmine.lan>
and subject line Re: [bug#48016] [PATCH] gnu: direnv: Install manpages
has caused the debbugs.gnu.org bug report #48016,
regarding [PATCH] gnu: direnv: Install manpages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
48016: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48016
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: direnv: Install manpages Date: Sun, 25 Apr 2021 19:43:08 +0800 User-agent: Mutt/1.9.4 (2018-02-28)

Hi guix,

The direnv package has manpages in the source repository, yet none are currently installed. This patch installs the manpages.

The patch was tested by installing and running direnv locally and viewing the manpages with man-db.

0001-gnu-direnv-Install-manpages.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#48016] [PATCH] gnu: direnv: Install manpages
>
>
>
>
> Date: 
>
> Sun, 25 Apr 2021 13:44:06 -0400
>
>
>
>
> On Sun, Apr 25, 2021 at 07:43:08PM +0800, Dion Mendel wrote:
> > The direnv package has manpages in the source repository, yet none are
> > currently installed.  This patch installs the manpages.
> > 
> > The patch was tested by installing and running direnv locally and viewing
> > the manpages with man-db.
>
> Good catch and thanks for the patch!
>
> > From 87fbd9f5d183b1912db186e7c5879566267655b8 Mon Sep 17 00:00:00 2001
> > From: Dion Mendel <guix@dm9.info>
> > Date: Sun, 25 Apr 2021 18:57:21 +0800
> > Subject: [PATCH] gnu: direnv: Install manpages
> > 
> > * gnu/packages/shellutils.scm (direnv): Install manpages.
>
> I tweaked the commit message and added you to the list authors of
> 'gnu/packages/shellutils.scm' ...
>
> > +         (add-after 'install 'install-manpages
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (let* ((out (assoc-ref outputs "out"))
> > +                    (man (string-append out "/share/man/man1")))
> > +               (mkdir-p man)
> > +               (with-directory-excursion "src/github.com/direnv/direnv"
> > +                 (install-file "man/direnv.1" man)
> > +                 (install-file "man/direnv-stdlib.1" man)
> > +                 (install-file "man/direnv.toml.1" man)
> > +               )
> > +               #t)))
>
> ... and I also removed this #t because it will not be necessary soon
> enough. I know that you were probably warned to include it, so I'm sorry
> about the contradictory advice.
>
> Pushed as 862a88612f903ffe5cca1213ba40010876d19c62
>
>
> --- End Message ---