bug#48230: closed ([PATCH] tests: go: Rename and fix duplicate test.)

[GNU bug Tracking System]

Your message dated Wed, 05 May 2021 01:03:54 -0400
with message-id <87y2ctkc05.fsf@gmail.com>
and subject line Re: [PATCH] tests: go: Rename and fix duplicate test.
has caused the debbugs.gnu.org bug report #48230,
regarding [PATCH] tests: go: Rename and fix duplicate test.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
48230: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48230
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] tests: go: Rename and fix duplicate test.
>
>
>
>
> Date: 
>
> Tue,  4 May 2021 22:55:48 +0200
>
>
>
>
> * tests/go.scm: Rename "go-version omited 'v' character" to
> "go-version without 'v' prefix" and change the code to match.
> ---
>
> Hi all,
>
> Found on a typo hunt.
>
> This is my best-effort guess at what was intended.  Maybe I'm mistaken: is 
> GO-VERSION->GIT-REF supposed to normalise "1.0.2" to "v1.0.2" instead?  Let me 
> know!
>
> Kind regards,
>
> T G-R
>
>  tests/go.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/tests/go.scm b/tests/go.scm
> index c33a834f69..565a0d451d 100644
> --- a/tests/go.scm
> +++ b/tests/go.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright � 2021 Fran�ois Joulaud <francois.joulaud@radiofrance.com>
> +;;; Copyright � 2021 Tobias Geerinckx-Rice <me@tobias.gr>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1
>    "v1.0.2"
>    (go-version->git-ref "v1.0.2"))
>  
> -(test-equal "go-version omited 'v' character"
> -  "v1.0.2"
> -  (go-version->git-ref "v1.0.2"))
> +(test-equal "go-version without 'v' prefix"
> +  "1.0.2"
> +  (go-version->git-ref "1.0.2"))
>  
>  (test-equal "go-version with embedded git-ref"
>    "65e3620a7ae7"
> -- 
> 2.31.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [PATCH] tests: go: Rename and fix duplicate test.
>
>
>
>
> Date: 
>
> Wed, 05 May 2021 01:03:54 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
>
>
>
>
> Hi Tobias!
>
> Tobias Geerinckx-Rice <me@tobias.gr> writes:
>
> > * tests/go.scm: Rename "go-version omited 'v' character" to
> > "go-version without 'v' prefix" and change the code to match.
> > ---
> >
> > Hi all,
> >
> > Found on a typo hunt.
>
> Eh, thank you!
>
> > This is my best-effort guess at what was intended.  Maybe I'm
> > mistaken: is GO-VERSION->GIT-REF supposed to normalise "1.0.2" to
> > "v1.0.2" instead?  Let me know!
>
> I wasn't sure anymore, so I looked at the code; go-version->git-ref is a
> no-op (leaves the version string intact) unless it matches
> %go-pseudo-version-rx.
>
> >  tests/go.scm | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/go.scm b/tests/go.scm
> > index c33a834f69..565a0d451d 100644
> > --- a/tests/go.scm
> > +++ b/tests/go.scm
> > @@ -1,5 +1,6 @@
> >  ;;; GNU Guix --- Functional package management for GNU
> >  ;;; Copyright  2021 Franois Joulaud <francois.joulaud@radiofrance.com>
> > +;;; Copyright  2021 Tobias Geerinckx-Rice <me@tobias.gr>
> >  ;;;
> >  ;;; This file is part of GNU Guix.
> >  ;;;
> > @@ -158,9 +159,9 @@ require github.com/kr/pretty v0.2.1
> >    "v1.0.2"
> >    (go-version->git-ref "v1.0.2"))
> >  
> > -(test-equal "go-version omited 'v' character"
> > -  "v1.0.2"
> > -  (go-version->git-ref "v1.0.2"))
> > +(test-equal "go-version without 'v' prefix"
> > +  "1.0.2"
> > +  (go-version->git-ref "1.0.2"))
>
> That test doesn't have much value based on my above analysis.  I suggest
> we drop it; it's testing the same thing as the "v1.0.2" case.
>
> I've removed it and pushed with commit 2354d79b88.
>
> Thank you!
>
> Maxim
>
>
> --- End Message ---