Re: "patch" to smtpmail.el

[Simon Josefsson]

Could someone please commit this?  It was acknowledged to work.  It
also fixes :version of an older patch.

Is it possible to get CVS write permission, btw?  How do I get that?

2002-05-07  Simon Josefsson  <address@hidden>

        * mail/smtpmail.el (smtpmail-send-it): Use user-mail-address from
        calling buffer.
        (smtpmail-auth-credentials): Bump :version to 21.4 (21.3 will not
        have the patch).

Index: smtpmail.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/mail/smtpmail.el,v
retrieving revision 1.41
diff -u -p -u -w -r1.41 smtpmail.el
--- smtpmail.el 26 Apr 2002 18:59:08 -0000      1.41
+++ smtpmail.el 7 May 2002 17:09:05 -0000
@@ -165,7 +165,7 @@ looks like address@hidden'."
                       (string  :tag "Username")
                       (choice (const :tag "Query when needed" nil)
                                       (string  :tag "Password")))))
-  :version "21.3"
+  :version "21.4"
   :group 'smtpmail)
 
 (defcustom smtpmail-starttls-credentials '(("" 25 "" ""))
@@ -218,6 +218,7 @@ This is relative to `smtpmail-queue-dir'
        (case-fold-search nil)
        delimline
        (mailbuf (current-buffer))
+       (user-mail-address user-mail-address)
        (smtpmail-code-conv-from
         (if enable-multibyte-characters
             (let ((sendmail-coding-system smtpmail-code-conv-from))

Simon Josefsson <address@hidden> writes:

> Gareth Owen <address@hidden> writes:
>
>> This makes the process-buffer inherit user-mail-address from the message
>> buffer.  Useful to stop your "real" email address leaking out in headers 
>> like X-From and X-Return-Path headers added by the SMTP agent.
>>
>> BCC'd to maintainer.
>
> Does this patch work instead?
>
> Index: smtpmail.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/mail/smtpmail.el,v
> retrieving revision 1.41
> diff -u -p -u -w -r1.41 smtpmail.el
> --- smtpmail.el       26 Apr 2002 18:59:08 -0000      1.41
> +++ smtpmail.el       7 May 2002 16:13:26 -0000
> @@ -218,6 +218,7 @@ This is relative to `smtpmail-queue-dir'
>       (case-fold-search nil)
>       delimline
>       (mailbuf (current-buffer))
> +     (user-mail-address user-mail-address)
>       (smtpmail-code-conv-from
>        (if enable-multibyte-characters
>            (let ((sendmail-coding-system smtpmail-code-conv-from))