Re: "patch" to smtpmail.el

[Simon Josefsson]

I committed something similar recently (rev 1.43).  Or were you
thinking about the variable name?  I chosed mail-address instead.

I don't understand why the previous idea didn't work though.
Shouldn't letting a variable to a variable take priority over the
buffer-local or global variable (as the case may be)?  Or is it
nonsensical to let a variable to itself just to work around its buffer
localness?  O well.

Richard Stallman <address@hidden> writes:

> I think this is a safer, cleaner way to write that change.
> Does it work?
>
> *** smtpmail.el.~1.42.~       Wed May  8 09:17:18 2002
> --- smtpmail.el       Wed May  8 22:50:36 2002
> ***************
> *** 220,225 ****
> --- 220,226 ----
>       (case-fold-search nil)
>       delimline
>       (mailbuf (current-buffer))
> +     (address user-mail-address)
>       (smtpmail-code-conv-from
>        (if enable-multibyte-characters
>            (let ((sendmail-coding-system smtpmail-code-conv-from))
> ***************
> *** 260,266 ****
>           ;; they put one in themselves.
>           (goto-char (point-min))
>           (if (not (re-search-forward "^From:" delimline t))
> !             (let* ((login user-mail-address)
>                      (fullname (user-full-name)))
>                 (cond ((eq mail-from-style 'angles)
>                        (insert "From: " fullname)
> --- 261,267 ----
>           ;; they put one in themselves.
>           (goto-char (point-min))
>           (if (not (re-search-forward "^From:" delimline t))
> !             (let* ((login address)
>                      (fullname (user-full-name)))
>                 (cond ((eq mail-from-style 'angles)
>                        (insert "From: " fullname)