[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: silly face function names

From: Robert J. Chassell
Subject: Re: silly face function names
Date: Fri, 20 Dec 2002 13:22:47 +0000 (UTC)

   Miles Bader <address@hidden> writes:

   > There are a number of face manipulation functions in faces.el of the
   > form `set-face-FOO-p'.  I think such names are misleading, ...

Yes, they are misleading.

As address@hidden (Kim F. Storm) says

   The names are badly chosen (having both 'set-' and '-p' is confusing),
   but if you read the names like this, it does make sense:

           set-face - FOO-p

which is true.  Kim then goes on to say

   IMHO, there is an abundance of silly functions and commands in
   faces.el; I don't see any reason to rename a few of them (which are
   rarely used anyway - I found only 5 places total).  

But even a few silly names should be fixed.  Our long term goal should
be code that is clear and meaningful, not misleading or silly.  That
means cleaning up previous silly messes.

As ESR said after he cleaned up a large number of messes for the shift
from GNU Emacs version 18 to version 19, "that was an Augean Stables."

    Robert J. Chassell                         Rattlesnake Enterprises
    http://www.rattlesnake.com                  GnuPG Key ID: 004B4AC8
    http://www.teak.cc                             address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]