[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: C-h k, C-h f and keyboard macros: Patch.

From: Kim F. Storm
Subject: Re: C-h k, C-h f and keyboard macros: Patch.
Date: 11 Feb 2003 16:36:41 +0100
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

address@hidden (Kim F. Storm) writes:

> Here is a version of the patch which fixes this problem:
> !       (let* ((remapped (and (symbolp function) (remap-command function)))

Thinking more about it, I would argue that since remap-command may in
practice be applied to anything that is found in a keymap (as was the
case here), it would be better to just return nil if the argument is
not a symbol.  I have just committed that change!

So with latest CVS head, the previous version of the patch is still ok:

Index: help-fns.el
RCS file: /cvsroot/emacs/emacs/lisp/help-fns.el,v
retrieving revision 1.28
diff -c -r1.28 help-fns.el
*** help-fns.el 4 Feb 2003 11:23:06 -0000       1.28
--- help-fns.el 11 Feb 2003 14:36:31 -0000
*** 323,328 ****
--- 323,331 ----
                 (car usage))
+               ((or (stringp def)
+                    (vectorp def))
+                (format "\nMacro: %s" (format-kbd-macro def)))
                (t "[Missing arglist.  Please make a bug report.]")))
        (let ((obsolete (and

Kim F. Storm <address@hidden> http://www.cua.dk

reply via email to

[Prev in Thread] Current Thread [Next in Thread]