emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Janitorial issues: Man-getpage-in-background


From: Kevin Rodgers
Subject: Re: Janitorial issues: Man-getpage-in-background
Date: Thu, 06 Mar 2003 12:57:31 -0700
User-agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:0.9.4.1) Gecko/20020406 Netscape6/6.2.2

Kai Großjohann wrote:

The function Man-getpage-in-background uses two different ways to set
environment variables:

(a) (let ((process-environment (copy-sequence process-environment)))
      (setenv "FOO" "bar")
      ...)

(b) (let ((process-environment (cons "FOO=bar" process-environment)))
      ...)

It looks really strange to see them both in the same function...

Okay to unify?  (I'd choose (a) unless there are objections.)

Objection!  (I've always wanted to say that :-)

On the basis of unnecessary cons'ing.

--
<a href="mailto:&lt;kevin.rodgers&#64;ihs.com&gt;";>Kevin Rodgers</a>






reply via email to

[Prev in Thread] Current Thread [Next in Thread]