[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: isearch hooks (was: query-replace-interactive not documented)

From: Miles Bader
Subject: Re: isearch hooks (was: query-replace-interactive not documented)
Date: Fri, 18 Jun 2004 21:10:05 -0400
User-agent: Mutt/1.3.28i

On Fri, Jun 18, 2004 at 11:00:09PM +0300, Juri Linkov wrote:
> The patch below adds two hooks `isearch-wrapped-hook' and
> `isearch-failed-hook'.

I like the idea, but a few comments:

 (1) I'm a bit confused about why there should be two hooks -- both are
     really instances of search failure, right?  Can they be combined?

 (2) The name `isearch-wrapped-hook' seems wrong anyway: the hook appears to
     be an _alternative_ to wrapping, not something that runs _after_
     wrapping, so something like `isearch-wrap-hook' seems more appropriate,
     (if this hook cannot be combined with the other hook).

 (3) It seems that these should be `-function' variables, not `-hook'
     variables, as they modify behavior instead of merely extending it, and
     multiple entries don't seem likely to work correctly.

 (4) Should the code set `isearch-wrapped' even when the user-function is
     run instead of the default code?


`...the Soviet Union was sliding in to an economic collapse so comprehensive
 that in the end its factories produced not goods but bads: finished products
 less valuable than the raw materials they were made from.'  [The Economist]

reply via email to

[Prev in Thread] Current Thread [Next in Thread]