defcustoms without group declaration (was: Gnus 5.10 is now on the trunk)

[Reiner Steib]

[ Including <address@hidden> ]

On Tue, Sep 07 2004, Kim F. Storm wrote:

> The following gnus related variables do not have a :group (or
> :variable-group) declaration, so they end up in the 'nil' group:
>
> gnus-parameter-to-address-alist
> gnus-parameter-go-list-alist
> gnus-parameter-subscribed-alist
> gnus-parameter-large-newsgroup-initial-alist
> mml-signencrypt-style-alist
> nntp-authinfo-file
> mml2015-unabbrev-trust-alist
>
> Can you pls. advise which group each of these belong to ?

Thanks for pointing this out.  I have commit the attached patch.  If
someone has a better suggestion, please speak up.

cvs diff: Diffing .
Index: ChangeLog
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/gnus/ChangeLog,v
retrieving revision 1.253
diff -u -r1.253 ChangeLog
--- ChangeLog   7 Sep 2004 03:47:58 -0000       1.253
+++ ChangeLog   8 Sep 2004 18:17:09 -0000
@@ -1,3 +1,19 @@
+2004-09-08  Reiner Steib  <address@hidden>
+
+       * nntp.el (nntp): New customization group.
+       (nntp-authinfo-file): Added customization group.
+
+       * mml2015.el (mml2015-unabbrev-trust-alist): Added customization
+       group.
+
+       * mml-sec.el (mml-signencrypt-style-alist): Ditto.
+
+       * gnus.el (to-address, to-list, subscribed)
+       (large-newsgroup-initial): Ditto.
+
+       * flow-fill.el (fill-flowed-display-column)
+       (fill-flowed-encode-column): Ditto.
+
 2004-09-06  Stefan  <address@hidden>
 
        * message.el (message-tokenize-header, message-send-mail-with-qmail):
Index: flow-fill.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/gnus/flow-fill.el,v
retrieving revision 1.5
diff -u -r1.5 flow-fill.el
--- flow-fill.el        4 Sep 2004 13:13:43 -0000       1.5
+++ flow-fill.el        8 Sep 2004 18:17:09 -0000
@@ -56,6 +56,7 @@
 (defcustom fill-flowed-display-column 'fill-column
   "Column beyond which format=flowed lines are wrapped, when displayed.
 This can be a Lisp expression or an integer."
+  :group 'mime-display
   :type '(choice (const :tag "Standard `fill-column'" fill-column)
                 (const :tag "Fit Window" (- (window-width) 5))
                 (sexp)
@@ -65,6 +66,7 @@
   "Column beyond which format=flowed lines are wrapped, in outgoing messages.
 This can be a Lisp expression or an integer.
 RFC 2646 suggests 66 characters for readability."
+  :group 'mime-display
   :type '(choice (const :tag "Standard fill-column" fill-column)
                 (const :tag "RFC 2646 default (66)" 66)
                 (sexp)
Index: gnus.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/gnus/gnus.el,v
retrieving revision 1.28
diff -u -r1.28 gnus.el
--- gnus.el     4 Sep 2004 13:13:43 -0000       1.28
+++ gnus.el     8 Sep 2004 18:17:10 -0000
@@ -1599,6 +1599,7 @@
  "Return GROUP's to-address."
  :variable-document
  "*Alist of group regexps and correspondent to-addresses."
+ :variable-group gnus-group-parameter
  :parameter-type '(gnus-email-address :tag "To Address")
  :parameter-document "\
 This will be used when doing followups and posts.
@@ -1625,6 +1626,7 @@
  "Return GROUP's to-list."
  :variable-document
  "*Alist of group regexps and correspondent to-lists."
+ :variable-group gnus-group-parameter
  :parameter-type '(gnus-email-address :tag "To List")
  :parameter-document "\
 This address will be used when doing a `a' in the group.
@@ -1643,6 +1645,7 @@
  "Return GROUP's subscription status."
  :variable-document
  "*Groups which are automatically considered subscribed."
+ :variable-group gnus-group-parameter
  :parameter-type '(const :tag "Subscribed" t)
  :parameter-document "\
 Gnus assumed that you are subscribed to the To/List address.
@@ -1749,6 +1752,7 @@
  "Return GROUP's initial input of the number of articles."
  :variable-document
  "*Alist of group regexps and its initial input of the number of articles."
+ :variable-group gnus-group-parameter
  :parameter-type '(choice :tag "Initial Input for Large Newsgroup"
                          (const :tag "All" nil)
                          (integer))
Index: mml-sec.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/gnus/mml-sec.el,v
retrieving revision 1.2
diff -u -r1.2 mml-sec.el
--- mml-sec.el  4 Sep 2004 13:13:43 -0000       1.2
+++ mml-sec.el  8 Sep 2004 18:17:11 -0000
@@ -83,6 +83,7 @@
 understood by all PGP implementations, in particular PGP version
 2 does not support it!  See Info node `(message)Security' for
 details."
+  :group 'message
   :type '(repeat (list (choice (const :tag "S/MIME" "smime")
                               (const :tag "PGP" "pgp")
                               (const :tag "PGP/MIME" "pgpmime")
Index: mml2015.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/gnus/mml2015.el,v
retrieving revision 1.2
diff -u -r1.2 mml2015.el
--- mml2015.el  4 Sep 2004 13:13:43 -0000       1.2
+++ mml2015.el  8 Sep 2004 18:17:11 -0000
@@ -83,6 +83,7 @@
     ("TRUST_FULLY"     . t)
     ("TRUST_ULTIMATE"  . t))
   "Map GnuPG trust output values to a boolean saying if you trust the key."
+  :group 'mime-security
   :type '(repeat (cons (regexp :tag "GnuPG output regexp")
                       (boolean :tag "Trust key"))))
 
Index: nntp.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/gnus/nntp.el,v
retrieving revision 1.22
diff -u -r1.22 nntp.el
--- nntp.el     4 Sep 2004 13:13:44 -0000       1.22
+++ nntp.el     8 Sep 2004 18:17:11 -0000
@@ -34,6 +34,10 @@
 
 (eval-when-compile (require 'cl))
 
+(defgroup nntp nil
+  "NNTP access for Gnus."
+  :group 'gnus)
+
 (defvoo nntp-address nil
   "Address of the physical nntp server.")
 
@@ -182,6 +186,7 @@
 
 (defcustom nntp-authinfo-file "~/.authinfo"
   ".netrc-like file that holds nntp authinfo passwords."
+  :group 'nntp
   :type
   '(choice file
           (repeat :tag "Entries"

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/