[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: obsolete comment in tool-bar.el

From: Stefan Monnier
Subject: Re: obsolete comment in tool-bar.el
Date: Thu, 21 Jul 2005 01:40:55 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

>    Loading a file should change Emacs's state as little as possible, so the
>    init-value of a minor mode should *describe* (not determine) the default
>    state of the minor-mode (in the case where the minor-mode function is not
>    executed).

> I understood that.  However setting the mode variable to t without
> enabling the mode has some very bad consequences, to the point that I
> believe it could be considered an outright bug.  If the mode has a
> lighter, the mode line claims that the mode is enabled, whereas it is
> not, confusing the user.  Even though the mode variable is non-nil,
> the mode is disabled, so `M-x foo-mode' should enable it.  Instead,
> `M-x foo-mode' is actually a no-op in this situation, which is also
> very confusing to the user.

No, you did not understand, please re-read.  Think about the difference
between describing and determining.  If without running the minor-mode
function its state is inactive, then the init-state has to be nil.
The init-state should only ever be t if the mode is active even without
having ever run the minor-mode function.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]