[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Toolbar patch (OS X)

From: YAMAMOTO Mitsuharu
Subject: Re: Toolbar patch (OS X)
Date: Tue, 27 Sep 2005 12:43:58 +0900
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/22.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI)

>>>>> On Mon, 26 Sep 2005 09:17:26 -0400, Stefan Monnier <address@hidden> said:

>> I'm attaching a patch which enables the toolbar button in the upper
>> right corner of each frame. This button is standard in OS X
>> applications and allows users to switch the toolbar on and off per
>> frame. The actual tool-bar switching functionality is already
>> present (frame parameter tool-bar-lines), here I'm just enabling
>> the button and its event-handling.

>> This has been in use in a couple of Aquamacs versions (>1500 users
>> currently), and the Japanese Carbon Emacs Package is using it too.

> I haven't looked at the code, but the functionality would be
> welcome.

One thing I'm concerned about is whether TOGGLE_TOOLBAR_EVENT deserves
a new constant in `enum event_kind' (in termhooks.h) or not.  Likewise
for `toggle-frame-toolbar' as a top-level Lisp event.  Are there any
guidelines about addition of new event kinds?  Once Kim F. Storm
suggested the `title-bar' prefix.


And as a general note, please enclose Mac OS X specific parts in
macfns.c and macterm.c with `#ifdef MAC_OSX' because these files are
also used by Mac OS Classic.

                                     YAMAMOTO Mitsuharu

reply via email to

[Prev in Thread] Current Thread [Next in Thread]