[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: C-g crash redux

From: Kim F. Storm
Subject: Re: C-g crash redux
Date: Fri, 04 Aug 2006 13:12:29 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Chong Yidong <address@hidden> writes:

>> But how do we ensure that waiting_for_user_input_p is restored
>> correctly on C-g?
>> Or isn't that necessary?
> That's not necessary, since quit_throw_to_read_char calls
> clear_waiting_for_input, which resets waiting_for_input to 0.

But it doesn't restore waiting_for_user_input_p to its
previous/original value.

Pls. see the comment about waiting_for_user_input_p in process.c.

> I guess someone worked all this out at some time in the past.  I added
> a comment to the code to clarify this.

I'm not sure someone worked this out originally.  

IIRC, the save/restore of waiting_for_user_input_p was added by
myself, and I doubt it was a concious decision at that time to use the
stack rather than unwind protect.

Kim F. Storm <address@hidden> http://www.cua.dk

reply via email to

[Prev in Thread] Current Thread [Next in Thread]