[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Code cleanup.

From: David Kastrup
Subject: Re: Code cleanup.
Date: Wed, 25 Oct 2006 21:01:34 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)

Richard Stallman <address@hidden> writes:

> The right time for code cleanup would be whenever we
> are installing new features.
> However, in my opinion, your change does not either increase
> or decrease readability.  It's a tossup.

Uh, setting tem to "", an artificial empty string, in order to have j
incremented once again before breaking out of the finished loop is

Is this kind of "readable" synonymous to "comprehensible with serious
effort", reminiscent of mathematicians' use of "trivial" as synonymous
with "provable with serious effort"?

If one hits a terminating condition of a loop, one should exit the
loop instead of setting up artificial values to variables that have
the only purpose of causing an exit at a convenient point later in

In other words: while "readability" is certainly a matter of personal
taste, you find me surprised at your taste.

I don't claim that my proposal was perfect, but I would not have
thought it a tossup.

I'll keep my version in my private tree, and will likely sneak it in
after the release.  At least I hope that nobody will find my proposal
actually strictly less readable than the original, and so we'll at
least get one developer (myself) marginally more happy without
offending others.

David Kastrup, Kriemhildstr. 15, 44793 Bochum

reply via email to

[Prev in Thread] Current Thread [Next in Thread]