[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fwd: vc-svn.el and "the underscore hack"

From: Stefan Monnier
Subject: Re: Fwd: vc-svn.el and "the underscore hack"
Date: Wed, 01 Nov 2006 11:29:23 -0500
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.90 (gnu/linux)

>> Would someone like to work on this?  There is a proposed patch
>> in the second message.

> I have tested this now on both windows and Gentoo GNU/Linux and have
> not encountered any issues.  However I have recently been using
> psvn.el from http://www.xsteve.at/prg/emacs/psvn.el and in that file
> they are using a defun to set the svn admin directory name. The
> function checks for environment to determine which directory name to
> use (.svn or _svn).  That looks like a better way to do it than what I
> did in my patch.  I will attempt to make a similar change to vc-svn.el
> and submit a patch if there are no objections.  

> I do have one question, is this list the correct place to post that
> patch or should it be sent to the subversion people.  vc-svn.el
> indicates that this file is maintained here.  I just wanted to make
> sure I send it to the right place.

As mentioned elsewhere the ".foo -> _foo" transformation is not specific to
Subversion and/or Emacs, so I think we should not handle it specially in
vc-svn.el but instead in a more generic way, maybe directly in the C code or
at least by providing a function that handles it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]