[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFA] Console based mouse face highlighting.

From: Eli Zaretskii
Subject: Re: [RFA] Console based mouse face highlighting.
Date: Fri, 18 May 2007 17:33:27 +0300

> From: Nick Roberts <address@hidden>
> Date: Fri, 18 May 2007 10:34:41 +1200
> Cc: address@hidden
>  > I suggested an alternative a few days ago: to add a new function, say,
>  > write_mouse_highlighted_glyphs, which does the same as write_glyphs,
>  > but uses the mouse face.  You could then call this function in the
>  > only place where you now need write_glyphs to use the mouse face.
>  > Would this solve the problem without any unnecessary overhead?
> That's another possibility, but it results in duplication of code 
> (write_glyphs
> is about 80 lines long) which adds to the burden of maintenance.

I don't think the burden is too big: write_glyphs is not a large
function, and insert_glyphs already uses this technique anyway.

> I think each approach has pros and cons; it's just a matter of choosing one.

I prefer the separate function approach.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]