[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFA] Console based mouse face highlighting.

From: Nick Roberts
Subject: Re: [RFA] Console based mouse face highlighting.
Date: Fri, 18 May 2007 10:34:41 +1200

 > > Well it means changes to write_glyphs and rif->write_glyphs in a dozen or
 > > so places in dispnew.c, and a change to x_write_glyph in xdisp.c at least
 > > (and perhaps w32con_write_glyphs).  If you're comfortable with those
 > > changes and still think it's the right approach, I'll do that.
 > I suggested an alternative a few days ago: to add a new function, say,
 > write_mouse_highlighted_glyphs, which does the same as write_glyphs,
 > but uses the mouse face.  You could then call this function in the
 > only place where you now need write_glyphs to use the mouse face.
 > Would this solve the problem without any unnecessary overhead?

That's another possibility, but it results in duplication of code (write_glyphs
is about 80 lines long) which adds to the burden of maintenance.

I think each approach has pros and cons; it's just a matter of choosing one.

Nick                                           http://www.inet.net.nz/~nickrob

reply via email to

[Prev in Thread] Current Thread [Next in Thread]