[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: find-file-noselect needs save-match-data

From: Stefan Monnier
Subject: Re: find-file-noselect needs save-match-data
Date: Tue, 05 Jun 2007 21:13:14 -0400
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux)

> While you're there, could you look at some other functions in
> files.el as well?  At least `convert-standard-filename',
> `file-truename', `file-name-sans-versions', `insert-directory',
> could benefit from `save-match-data' too.

No.  Most functions should not need to save-match-data (which is an
expensive operation very rarely needed).  The place to save-match-data is
typically on functions that use regexps and are placed on some sensitive
hooks (or at the pbvious place when a function needs to call
regexp-manipulating code between a regexp-match and its use of the


reply via email to

[Prev in Thread] Current Thread [Next in Thread]