[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adding parameters to windows

From: Juanma Barranquero
Subject: Re: Adding parameters to windows
Date: Wed, 4 Jun 2008 23:13:06 +0200

On Wed, Jun 4, 2008 at 5:10 PM, Stefan Monnier <address@hidden> wrote:

> Can someone fix up those things and commit this patch, please?

I commited it.

I've done a few trivial changes:

 - making the argument of `window-parameters' optional, as the
docstring suggests
 - args are consistently called WINDOW, PARAMETER and VALUE.
 - I've documented the return value of `set-window-parameter' (seems
silly to return it and not document it).


 - What does mean "The meaningful PARAMETERs depend on the kind of
window." Which parameters are meaningul, and for which windows?

 - It is wise to return (in `window-parameter' and
`set-window-parameter') directly the parameter alist, instead of a
copy of it?

> And add a note to etc/NEWS about it?

Sorry, I'm *horrible* at deciding what to write in NEWS...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]