[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Yanking isearch to highlight-regexp

From: Stefan Monnier
Subject: Re: Yanking isearch to highlight-regexp
Date: Sun, 29 Jun 2008 14:07:39 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

> Now here is a patch for hi-lock.el that uses `read-regexp'.
> It also marks `hi-lock-regexp-history' as an obsolete variable
> that is replaced with `regexp-history'.

Sounds good.

> Another change is renaming `hi-lock-face-history' to
> `hi-lock-face-defaults' and putting the face list to the
> minibuffer's default list instead of the history list:

Why is that good?

>                           (try-completion
> !                          (substring (car hi-lock-face-history) 0 1)
>                            (mapcar (lambda (f) (cons f f))
> !                                  hi-lock-face-history))))

I believe the "(mapcar (lambda (f) (cons f f))" can be removed, since
try-completion accepts lists of strings since Emacs-21 IIRC.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]