[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacsclient's option decoding code
From: |
Juanma Barranquero |
Subject: |
Re: emacsclient's option decoding code |
Date: |
Wed, 12 Nov 2008 22:05:11 +0100 |
On Wed, Nov 12, 2008 at 20:14, Eli Zaretskii <address@hidden> wrote:
>> - "0.0" will have to be checked specially
>
> "checked specially" where?
Currently, ":0.0" would work for Windows because of the
Windows-specific "any DISPLAY string is valid" code. Removing that,
":0.0" would be passed to the following code:
(t
(unless (string-match-p "\\`[^:]*:[0-9]+\\(\\.[0-9]+\\)?\\'" display)
(error "Invalid display, not HOST:SERVER or HOST:SERVER.SCREEN"))
(when (and (boundp 'x-initialized) (not x-initialized))
(setq x-display-name display)
(x-initialize-window-system))
(make-frame `((window-system . x)
(display . ,display) . ,parameters)))))
and it would fail for Windows. At some point or other, you've gonna
add a check for Windows, because, really, ":0.0" has no meaning right
now.
> I thought that uniform behavior in common use-cases could make
> maintenance easier.
I agree. But the things we've been discussing until now aren't more
uniform IMO; they just move the Windows specific code around or
introduce ad-hoc hacks to force Windows frames to simulate being what
they are not...
Juanma
- Re: emacsclient's option decoding code, (continued)
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/11
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/11
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/11
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/11
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/11
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/12
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/12
- Re: emacsclient's option decoding code,
Juanma Barranquero <=
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/12
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/13
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/12
- Re: emacsclient's option decoding code, Stefan Monnier, 2008/11/11
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/12
- Re: emacsclient's option decoding code, Stefan Monnier, 2008/11/12
- Re: emacsclient's option decoding code, Juanma Barranquero, 2008/11/12
- Re: emacsclient's option decoding code, Stefan Monnier, 2008/11/12
- Re: emacsclient's option decoding code, Lennart Borgman, 2008/11/12
- Re: emacsclient's option decoding code, Eli Zaretskii, 2008/11/12