[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: VC Development

From: Chong Yidong
Subject: Re: VC Development
Date: Sun, 01 Feb 2009 09:25:55 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)

Nick Roberts <address@hidden> writes:

> OK.  I see now that I should have used copy-keymap:
> (defvar vc-dir-mouse-map
>   (let ((map (copy-keymap vc-dir-mode-map)))
>    ...
> I would like to see this change go in before the pretest.  Since I'm
> evidently in Dan's killfile this must be a request to the maintainers.
> In case there is any confusion, with my proposed change, mouse-2 still
> toggles the mark when clicked over the status (first mouse highlight
> region) but over the filename (second mouse highlight region) now
> visits that file in another buffer.

Unfortunately, I am not familiar enough with the VC code to make a good
technical judgement call in this case.  IMO, your change is not an
obvious improvement---the check-box interface I mentioned seems to be a
more intuitive way to toggle the mark with the mouse.  So, I prefer to
stick with the current state of affairs (i.e., how vc-dir has been
behaving since it was written), until that interface can be implemented.

> I would also like to see stay-local behaviour working.  I can look at
> making vc-svn-registered not use "svn status -v DIR", so that
> vc-stay-local-p is not so slow, but clearly it is not worthwhile if
> Dan is going to revert all my changes and refuse to discuss the
> reasons why.

I think using the local directory tree is the correct thing to do.  It
is clearly not feasible to implement and test it before the pretest, but
please try working on it.  (Stefan, any thoughts?)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]