[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Virtual Info files and nodes

From: Stefan Monnier
Subject: Re: Virtual Info files and nodes
Date: Mon, 29 Jun 2009 10:42:28 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.94 (gnu/linux)

>> - Why regexps for filenames?
> This is a forethought for possible future cases.  But maybe only strings
> should be allowed now, and regexps can be added only when necessary.

Nah, you might as well stick to regexps indeed.  I'm not sure what
I was thinking.

>> - Why check (stringp filename) in Info-virtual-file?  Isn't it an
>> error to call it with something else than a string.
> Really only nil can be expected now,

Can it?  In which circumstance?

> but `stringp' is a precaution
> against t (the current internal value for "dir" ) and former symbol
> values `apropos', `toc' (maybe some external packages still use them).

Please mention it in a comment.

>> - Why have separate Info-virtual-file and Info-virtual-node functions?
>> (the latter is only called (once) from Info-virtual-fun, and the former
>> is called once from Info-virtual-fun and another time where it seems
>> that Info-virtual-fun could be used in its stead).

> Info-virtual-fun expects an argument `op' for an operation type,
> but these places call (Info-virtual-file file) with only a file name
> argument to check whether a file name is virtual (if its name is defined
> in a list of definitions of virtual Info files).

Why not provide a dummy `find-file' value for the `op'?
And wrap this in an Info-virtual-file-p function?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]