[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PATCH term optional bold
From: |
Stefan Monnier |
Subject: |
Re: PATCH term optional bold |
Date: |
Fri, 11 Sep 2009 13:48:31 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) |
> This small patch make optional the usage of bold attribute in term.
Could you give us some background explaining the motivation for this?
> +(defvar term-enable-bold t
> + "Set to nil to disable bold")
[...]
> - (when term-ansi-current-bold
> + (when (and term-ansi-current-bold
> + term-enable-bold)
> (setq term-current-face
> (append '(:weight bold) term-current-face)))
[...]
> - (when term-ansi-current-bold
> + (when (and term-ansi-current-bold
> + term-enable-bold)
> (setq term-current-face
> (append '(:weight bold) term-current-face)))
I think it'd be even better to do something like
> +(defvar term-bold-attribute '(:weight bold)
> + "Set to nil to disable bold")
[...]
> (when term-ansi-current-bold
> (setq term-current-face
> - (append '(:weight bold) term-current-face)))
> + (append term-bold-attribute term-current-face)))
[...]
> (when term-ansi-current-bold
> (setq term-current-face
> - (append '(:weight bold) term-current-face)))
> + (append term-bold-attribute term-current-face)))
WDYT?
Stefan