emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Buffer size limitation in insdel.c


From: Lars Magne Ingebrigtsen
Subject: Re: Buffer size limitation in insdel.c
Date: Thu, 23 Sep 2010 14:47:23 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux)

A few general questions:

dispnew.c:783: warning: conversion to 'int' from 'Lisp_Object' may alter its 
value

      matrix->window_left_col = WINDOW_LEFT_EDGE_COL (w);

What's the right fix here?  make window_left_col EMACS_INT, and slap an
XINT around the WINDOW_LEFT_EDGE_COL?

Are these interesting at all?  That is, conversions that may
theoretically change signs, but it's really unlikely?

dispnew.c:2178: warning: conversion to 'long unsigned int' from 'short int' may 
change the sign of the result

      size_t nbytes = from->used[TEXT_AREA] * sizeof (struct glyph);

Perhaps dispnew.c wasn't an optimal place to start poking around.  :-)      

-- 
(domestic pets only, the antidote for overdose, milk.)
  address@hidden * Lars Magne Ingebrigtsen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]