[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] Review uuid.el -- library for UUID generation

From: Chong Yidong
Subject: Re: [RFC] Review uuid.el -- library for UUID generation
Date: Sat, 13 Nov 2010 11:56:20 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Kan-Ru Chen <address@hidden> writes:

> I recently started a new library project, uuid-el, for generating UUIDs
> for RSS feeds, or other places where UUID are used.  Since this is my
> first serious elisp program--a relatively simple one though--I'd like to
> take the chance to improve the code and to learn some conventions.

Pretty good for a first elisp program.  I don't see any convention
violations.  Just one minor nitpick:

  (let ((address (uuid-get-ieee-address)))
    (mapconcat (lambda (var) (format "%02x" var))
               address "")

Try not to leave close parentheses on lines by themselves; this tends to
annoy Lisp programmers.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]