[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for fields of `struct buffer'

From: Tom Tromey
Subject: Re: Patch for fields of `struct buffer'
Date: Tue, 08 Feb 2011 14:21:02 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Stefan> Please use an enum type rather than a char for the "type" field.


Stefan> I'd have used a singly-linked list or a "xrealloc (twice the size)"
Stefan> scheme, to avoid allocating N^2 amount of memory.  But I guess it
Stefan> doesn't matter for make-docfile.

I did the size-doubling thing.

Stefan> Better use `switch'.


Stefan> The rest looks good, thank you.

I am going to commit it once my bootstrap finishes successfully.
This may break the Windows build, or other builds.  I have no way to
test that.  I can provide some support for fixing problems, though.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]