[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for fields of `struct buffer'
From: |
Paul Eggert |
Subject: |
Re: Patch for fields of `struct buffer' |
Date: |
Tue, 01 Feb 2011 16:44:34 -0800 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7 |
On 02/01/11 13:59, Tom Tromey wrote:
> +gl-stamp: $(ALL_SOURCES)
> + @rm -f gl-tmp
> + echo "/* This file was auto-generated */" > gl-tmp
> + echo "/* DO NOT EDIT */" >> gl-tmp
> + echo "struct emacs_globals {" >> gl-tmp
> + ...
It'd be better to package that shell-script code into
a shell script named (say) globals.sh. Then the make
rule could be much simpler:
$(srcdir)/gl-stamp: $(ALL_SOURCES) $(srcdir)/globals.sh
rm -f gl-stamp.tmp
$(srcdir)/globals.sh $(ALL_SOURCES) >gl-stamp.tmp
$(srcdir)/../move-if-change gl-stamp.tmp $@
and there would be no need for the files globals-1.sed and
globals-2.sed, as their contents could be put into strings in
gl-stamp.sh.
The rule for "make clean" should also remove *.tmp, to clean
any leftover temporaries.
> +ALL_SOURCES = alloc.c atimer.c bidi.c buffer.c bytecode.c callint.c \
These files all need $(srcdir)/ prepended to their names.
- Re: Patch for fields of `struct buffer', (continued)
- Re: Patch for fields of `struct buffer', Andreas Schwab, 2011/02/01
- Re: Patch for fields of `struct buffer', Tom Tromey, 2011/02/01
- Re: Patch for fields of `struct buffer', Tom Tromey, 2011/02/08
- Re: Patch for fields of `struct buffer', Stefan Monnier, 2011/02/08
- Re: Patch for fields of `struct buffer', Tom Tromey, 2011/02/08
- Re: Patch for fields of `struct buffer', Tom Tromey, 2011/02/08
- Re: Patch for fields of `struct buffer', Stefan Monnier, 2011/02/09
- Re: Patch for fields of `struct buffer', Andreas Schwab, 2011/02/08
Re: Patch for fields of `struct buffer', Stefan Monnier, 2011/02/01