[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Installing `struct buffer' patch
From: |
Chong Yidong |
Subject: |
Re: Installing `struct buffer' patch |
Date: |
Mon, 14 Feb 2011 11:42:56 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
Tom Tromey <address@hidden> writes:
> It may break some builds that I cannot test. However, in all cases, the
> fix is simple. The patch renames the fields of `struct buffer', so when
> you see an error arising from `something->field', you can simply change
> that to read `B_ (something, field)'. Please do not change any code to
> use `BUFFER_INTERNAL_FIELD'.
Hmm, I just realized that the B_ macro doesn't make for very
understandable code. The name is too cryptic.
What do you think about replacing B_ with lots of individual macros,
like BUF_UNDO_LIST, BUF_NAME, etc.? This might be ugly in buffer.h, but
the rest of the code would be more understandable.
- Re: Patch for fields of `struct buffer', (continued)
Re: Patch for fields of `struct buffer', Richard Stallman, 2011/02/01
- Re: Patch for fields of `struct buffer', Tom Tromey, 2011/02/01
- Re: Patch for fields of `struct buffer', Tom Tromey, 2011/02/11
- Re: Patch for fields of `struct buffer', Richard Stallman, 2011/02/12
- Installing `struct buffer' patch (Was: Patch for fields of `struct buffer'), Tom Tromey, 2011/02/13
- Re: Installing `struct buffer' patch,
Chong Yidong <=
- Re: Installing `struct buffer' patch, Tom Tromey, 2011/02/14
- Re: Installing `struct buffer' patch, Chong Yidong, 2011/02/14
- Re: Installing `struct buffer' patch, Tom Tromey, 2011/02/14
- Re: Installing `struct buffer' patch, Stefan Monnier, 2011/02/14
- Re: Installing `struct buffer' patch, Chong Yidong, 2011/02/15
- Re: Installing `struct buffer' patch, Tom Tromey, 2011/02/16
Re: Installing `struct buffer' patch, Richard Stallman, 2011/02/15
Re: Installing `struct buffer' patch, Glenn Morris, 2011/02/14
Re: Installing `struct buffer' patch, Tom Tromey, 2011/02/15
Re: Patch for fields of `struct buffer', Daniel Colascione, 2011/02/01