[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] window.el: Improve mark management

From: Stefan Monnier
Subject: Re: [PATCH] window.el: Improve mark management
Date: Fri, 20 Jan 2012 13:25:49 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)

>> I'm not completely sure.  The current code doesn't seem that bad since,
>> as you say, it basically reproduces the behavior of
>> window-configurations.
>> So I'd like to first hear of what are concrete cases where the current
>> behavior is a problem.
> It's very simple : with the current code, when you call the
> `window-state-put' function, the mark is restored as active.

That's easy to fix: use (set-marker (mark-marker)) instead of set-mark.

> - Either, remove all the mark stuff from `window-state-get' and
> `window-state-put' functions.

That's not a bad idea, actually.


PS: BTW, the "multiple push-mark" issue can be solved by saving the mark
only once per buffer rather than once per window (i.e. the window-state
object would have a separate list of affected buffers with their
corresponding state, including the mark, not sure what else could be

reply via email to

[Prev in Thread] Current Thread [Next in Thread]