[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] window.el: Improve mark management

From: Stefan Monnier
Subject: Re: [PATCH] window.el: Improve mark management
Date: Tue, 24 Jan 2012 15:31:25 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)

>> >> I'm not completely sure.  The current code doesn't seem that bad since,
>> >> as you say, it basically reproduces the behavior of
>> >> window-configurations.
>> >> So I'd like to first hear of what are concrete cases where the current
>> >> behavior is a problem.
>> > It's very simple : with the current code, when you call the
>> > `window-state-put' function, the mark is restored as active.
>> That's easy to fix: use (set-marker (mark-marker)) instead of set-mark.
> Interesting.

It's actually a trivial bug-fix.

>> > - Either, remove all the mark stuff from `window-state-get' and
>> > `window-state-put' functions.
>> That's not a bad idea, actually.
> Yes that's was my first idea in fact. After this discussion I think
> it's the good thing to do and ou I attached the corresponding patch to
> this email.  `window-state-get' and `window-state-put' should not deal
> with mark as it's not relevant at all and leads to an unexpected
> behavior from user point of view.

I tend to agree.  Martin, what do you think?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]