[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107264: shr.el (shr-rescale-imag

From: Stefan Monnier
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107264: shr.el (shr-rescale-image): Allow viewing large images.
Date: Mon, 13 Feb 2012 16:24:26 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux)

>> The whole purpose of max-image-size was to avoid crashes and
>> denial-of-service, for example when viewing incorrectly-labeled images.
>> So it's especially important for SHR which will display images
>> downloaded from anywhere.
> shr.el (if compiled with imagemagick support) will (by default) rescale
> the images down.  But to do that, it goes through the display engine,
> anyway, so it's an issue anyway.
> But what crashes and denials of service does `create-image' on a large
> image result in?

We had a few bug reports: some incorrectly labeled images seemed to
indicate insanely large size, which resulted in crashes because malloc
failed, while other large images resulted in problems because of
allocation of very large blocks of memory for the image.
A quick search pointed me to the thread at
which doesn't show concrete bugs, but should give you some context.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]