[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107264: shr.el (shr-rescale-imag

From: Paul Eggert
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107264: shr.el (shr-rescale-image): Allow viewing large images.
Date: Tue, 14 Feb 2012 07:56:28 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0

On 02/14/2012 06:49 AM, Lars Ingebrigtsen wrote:
> I think the limit should be set to something that gives as little
> problems to real-world usage as realistic.  6.0 is too small, nil is
> unresponsible, and 60.0 is probably too large.  10.0?

10.0 would be fine, I think, not too large for older desktops with
big displays.  The current value of 6.0 was established in 2005,
and the typical ratio of RAM to display size for older machines
has probably grown by a factor of (10/6)**2 since then.

But it should be 10.0 everywhere, no?  Not just in Gnus.  That is,
shouldn't the change be something like this?

=== modified file 'lisp/gnus/shr.el'
--- lisp/gnus/shr.el    2012-02-13 11:25:56 +0000
+++ lisp/gnus/shr.el    2012-02-14 15:54:44 +0000
@@ -557,8 +557,7 @@
     (insert alt)))
 (defun shr-rescale-image (data)
-  (let* ((max-image-size nil)
-        (image (create-image data nil t :ascent 100)))
+  (let ((image (create-image data nil t :ascent 100)))
     (if (or (not (fboundp 'imagemagick-types))
            (not (get-buffer-window (current-buffer))))

=== modified file 'src/image.c'
--- src/image.c 2012-02-07 03:46:18 +0000
+++ src/image.c 2012-02-14 15:54:07 +0000
@@ -976,7 +976,7 @@
 static void free_image (struct frame *f, struct image *img);
-#define MAX_IMAGE_SIZE 6.0
+#define MAX_IMAGE_SIZE 10.0
 /* Allocate and return a new image structure for image specification
    SPEC.  SPEC has a hash value of HASH.  */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]