[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: For insertion in trunk

From: Glenn Morris
Subject: Re: For insertion in trunk
Date: Tue, 26 Jun 2012 21:24:01 -0400
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Katsumi Yamaoka wrote:

> I've set no-byte-compile and no-update-autoloads in those files.

OK, that works as a stopgap.

> (I'm going to try rebuilding now, though it takes time on Cygwin.)

Hydra will do it for you:

It's a nice service, although it has a few too many false build failures
(full disk, missing dependency, some other glitch, etc).

>> In any case surely these test files should be under test/, not lisp/?
> Currently those modules are of no use for the run time I believe.
> I only did sync of Ma Gnus and Emacs.

I don't understand. Not being used at runtime means they should go in
test/, like every other test file (including gnus-test.el).

They are no use at all in Emacs if they rely on parts of Gnus that are
not present though (whatever gnus-load is).

Also (my pet peeve) the license headers are obviously wrong in two of

  ;; This file is not part of GNU Emacs.
  ;; If not, write to the Free Software Foundation, Inc., 51 Franklin
  ;; Street, Fifth Floor, Boston, MA 02110-1301, USA.

The modern version uses a URL instead of a street address.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]