[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from

From: martin rudalics
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from deleted buffers, windows and frames.
Date: Thu, 06 Sep 2012 16:42:11 +0200

> No, there can be perfectly valid reasons to access
> a deleted/killed object.

Its components?

> I don't see anything that needs fixing here.  On the contrary.  It can
> be very useful to keep a reference to a frame/window, and when you need
> to display data, see if it's still live, and if not create a new one,
> initializing some of its parameters from the old deleted one.

Do you really do that?  Currently, the window must be valid for that
purpose.  So some of your code must be broken.

> I strongly disagree.  I think you have an incorrect understanding of
> what a "deleted/killed" object is.  It really isn't dead at all.

IMHO WINDOWP is often used where WINDOW_LIVE_P should be used instead.

> Obviously, we don't want to NULL/nil all fields blindly.  We want to do
> it parsimoniously, so that we only do it for fields which we know can
> safely be set this way, and ideally only for fields which do hold on to
> too much data (e.g. not for fields which only contain numbers anyway).

Fully agreed.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]