[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r108143: run-hooks-with-args-*

From: Eli Zaretskii
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r108143: run-hooks-with-args-* do fixes (bug#12393)
Date: Tue, 18 Sep 2012 09:37:28 +0300

> From: Stefan Monnier <address@hidden>
> Date: Tue, 18 Sep 2012 00:10:16 -0400
> Cc: address@hidden
> > -the given arguments and its return value is returned.
> > +the given arguments.  Then we return nil if the function returns nil,
> > +and t if it returns non-nil.
> Let's not force ourselves to return t.  IOW `non-nil' would be better.

Also, a stylistic issue: we don't normally say "we return" in
documentation, since it's not clear who are "we" in this context.
Something like this would be better:

  The value returned is nil if the function returns nil, non-nil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]