[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r108143: run-hooks-with-args-*

From: Stefan Monnier
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r108143: run-hooks-with-args-* do fixes (bug#12393)
Date: Tue, 18 Sep 2012 08:27:30 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux)

>> That seems redundant, since if the hook is nil, all the functions on the
>> hook return nil.
> No harm in being explicit though?

No, no harm (other than being a bit verbose).
>>> -the given arguments and its return value is returned.
>>> +the given arguments.  Then we return nil if the function returns nil,
>>> +and t if it returns non-nil.
>> Let's not force ourselves to return t.  IOW `non-nil' would be better.
> I thought about that, but wanted to make it clear that we do not return
> the same non-nil value as the function.

Saying it returns `non-nil' is already very different from saying it
returns that function's value.

> (Althought that is how it behaved until 24.1, when it was changed with
> no annoucement and no doc update.)

And it might change again in the future, that's why I don't want to be
specific when there's no need to be.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]