[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requo

From: Stefan Monnier
Subject: Re: [Emacs-diffs] trunk r113958: * minibuffer.el (completion--sifn-requote): Bind `non-essential'.
Date: Wed, 21 Aug 2013 16:08:40 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

>> My point is simply that the backtrace you show does not seem to perform
>> non-essential work, so binding non-essential is not right.  It is
>> computing the completion of /ssh:address@hidden:/ (not quite sure
>> why, since the backtrace doesn't go further up).
> The whole backtrace is in
> <http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00533.html>
> (the second backtrace in this message).

So we're in the middle of minibuffer--complete-and-exit which calls
try-completion.  That's very definitely not "non-essential".

>> At the same time I wonder why (substitute-in-file-name
>> "/ssh:address@hidden") should signal an error: it looks like an
>> incomplete filename, so we don't know yet whether it'll really be an
>> error or not.
> For Tramp, it is a complete filename wrt syntax. "ssh" is recognised as
> host name, which is regarded as an error since we had decided this some
> weeks ago. See <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13900#24>.

Yes, it could be a "complete but ambiguous/erroneous" file name, but it
could also be a "not yet complete file name".  So maybe, if there's no
":" nor "/" after "/ssh:", we should refrain from signaling an error.

> Setting `non-essential' to t is a mean to tell Tramp not to check this.

I do know that, but that's just an ugly hack here, since the code is not


reply via email to

[Prev in Thread] Current Thread [Next in Thread]