[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Finding packages to enable by default

From: Stefan Monnier
Subject: Re: Finding packages to enable by default
Date: Wed, 11 Dec 2013 09:13:49 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

>> (save-excursion
>> -               (goto-char blinkpos)
>> -               (sit-for blink-matching-delay))))
>> +               (move-overlay blink-matching--overlay blinkpos (1+ blinkpos)
>> +                             (current-buffer))
>> +               (overlay-put blink-matching--overlay
>> +                            'priority show-paren-priority)
>> +               (sit-for blink-matching-delay)
>> +               (delete-overlay blink-matching--overlay))))
> I think there's no more need to save the excursion here.

Agreed.  OTOH there is a strong need for unwind-protect, in case the
user hits C-g during the delay.

One other problem: the show-paren-match face should be moved to
simple.el or faces.el.

> But maybe someone likes the old behavior and we should provide an option
> (like a special value 'jump for `blink-matching-paren') to support it.

I agree with Dmitry that we can wait.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]