[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Feature freeze

From: Stefan Monnier
Subject: Re: Feature freeze
Date: Mon, 06 Jan 2014 19:19:47 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

> Is it OK to install, or will it have to wait?

Looks OK.  Please install, tho see nitpicks below.

> +  ;; Describe all the slots in this class

Please punctuate the comments (IIUC you didn't actually change this
comment, but while you're there, you might as well do it ;-).

> +(defvar help-fns-describe-function-functions nil
> +  "List of functions to run in help buffer in `describe-function'.
> +Those functions will be run after the header line and argument
> +list was inserted, and before the documentation will be inserted.
> +The functions will receive the function name as argument.")
> +
>  ;; Functions
>  ;;;###autoload
> @@ -653,7 +659,7 @@
>            (help-fns--compiler-macro function)
>            (help-fns--parent-mode function)
>            (help-fns--obsolete function)
> -
> +       (run-hook-with-args 'help-fns-describe-function-functions function)

Looks good, but please move help-fns--compiler-macro,
help-fns--parent-mode, help-fns--obsolete to
help-fns-describe-function-functions while you're there.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]