[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: About the :distant-foreground face attribute

From: Jan D.
Subject: Re: [PATCH] Re: About the :distant-foreground face attribute
Date: Tue, 14 Jan 2014 10:34:31 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:17.0) Gecko/20130328 Thunderbird/17.0.5

Daniel Colascione skrev 2014-01-14 09:18:
On 01/13/2014 11:47 PM, Jan D. wrote:
Your mailer does not quote replies properly, which is distracting.  Can
you fix that?

It looks fine to me.

It seems to quote only the first line, and not subsequent lines. You can easily see this in the web archive for emacs-devel.

Given the use case at hand, we know for a fact that the background is
the region background, so I don't understand why a calculated foreground
is needed.  Just pick one that matches the background.
There might be other use cases where a calculated foreground makes
sense, but my imagination fails me here.

Calculated foreground colors look better: they resemble the font-lock
colors on which they're based.

For the region case, that would imply the possibility of different foregrounds for marked text, none which is the actual font-lock color. That is just confusing. Also, "look better" is just subjective, a theme designer should deside what looks best, not Emacs code.

Again, I really don't see this use case.  Do you have one?

I just mentioned one. See my other email, the one where I laid out the
options for Emacs configuration defaults.

That is not a use case. A use case describes what an actual user does and in what situation automatically calculates colors enters the picture.

We should push policy to user customization when
possible instead of hardcoding policy in the logic of face attributes.

I don't think we do that, users can still customize faces as they see

:distant-foreground has far too narrow a justification to warrant being
a face property by itself.

Also, just an opinion, not based on some documented design rule in any Emacs or GNU document. IMHO :stipple is as narrow.

        Jan D.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]