[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] About the :distant-foreground face attribute

From: Daniel Colascione
Subject: Re: [PATCH] About the :distant-foreground face attribute
Date: Wed, 15 Jan 2014 00:05:56 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

On 01/14/2014 10:33 PM, Jan Djärv wrote:
This is currently for NS/Gtk+ only.  For Lucid/Motif/No toolkit, we don't use
system colors at all, because they are not known and can not be known,
because the API to get them is not available.

You're applying this principle very selectively.

System background + contrast problem => system foreground.
How is that selectively, it is a clear rule.

It's clear, but arbitrary. Another clear and arbitrary rule is this:
You're merely stated your conclusion. You think it's okay
  System background + contrast problem => adjust foreground.

You haven't presented any justification for your arbitrary rule being better 
than my arbitrary rule.

I have stated my justification as such: User and system
configurations should override Emacs settings and code in the default
case, i.e. when the user has made no explicit customization in

You haven't stated any justification at all. All you've done is re-assert your position. You clearly think it's okay for Emacs to override the foreground selection color in some circumstances, otherwise you'd support keeping the 24.3 behavior. You're justifying your particular strategy for handling contrast inherent in the new behavior by invoking a principle you *JUST VIOLATED* by creating the problematic new behavior.

We have to do something about contrast problems. Why do you think your solution produces better results than mine? If, to render something the user can actually read, we have to choose a foreground color other than what normal face logic would produce, why use the system selection foreground color instead of some other color we algorithmically create?

Please don't invoke the "system settings should override Emacs" crap again: that idea clearly doesn't hold in the case we're talking about.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]